Conversation
Adds a `wp-subdomain` prompt to the `github:add-checklist` command that can then be used to parse launch checklists found in the `special-projects-checklists` repo. Specifically, we want to avoid adding of testing for a `www` sub-subdomain in the `launch-site.md` [checklist](https://github.com/a8cteam51/special-projects-checklists/blob/trunk/checklists/launch/launch-site.md), since doing so is an unsupported anti-pattern: pMz3w-lWV-p2
WalkthroughAdds a new conditional tag key 'wp-subdomain' to GitHub_Checklist_Add’s CONDITIONAL_TAGS. This enables checklists to gate sections based on whether the final URL will be a WordPress.com or WordPress.org subdomain. When present in fetched checklists, initialization will prompt for this tag and store its boolean value. Checklist processing will recognize the tag and include or exclude tagged sections accordingly. No other control flow, error handling, or public/exported declarations are changed. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
commands/GitHub_Checklist_Add.php (2)
72-75: Nit: Refine prompt copy for clarity and add examplesSuggest clarifying the user prompt intent and including examples. This reduces ambiguity around “final URL” and hints at the “no www” context without over-explaining.
- 'wp-subdomain' => array( - 'question' => 'Will the final URL be a subdomain of WordPress.com or WordPress.org?', - 'description' => 'The site uses a subdomain of WordPress.com or WordPress.org.', - ), + 'wp-subdomain' => array( + 'question' => 'Will the final production URL be a WordPress.com or WordPress.org subdomain (e.g., example.wordpress.com, make.wordpress.org)?', + 'description' => 'The site uses a WordPress.com or WordPress.org subdomain.', + ),
72-75: Verify special-projects-checklists for wp-subdomain gatingThe automated clone of a8cteam51/special-projects-checklists failed (repo not found), so please manually confirm that your new
wp-subdomaintag is being applied in the launch-site checklist to skip “www” validations. Specifically:• In
checklists/launch/launch-site.md, wrap any “www” checks with either
[not:wp-subdomain] … [/not:wp-subdomain](for subdomain sites), or[wp-subdomain] … [/wp-subdomain](if you only want to run the section when on a WordPress subdomain)If those gates are missing, open a follow-up PR against special-projects-checklists to add them around the “www” sections.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
commands/GitHub_Checklist_Add.php(1 hunks)
🔇 Additional comments (1)
commands/GitHub_Checklist_Add.php (1)
72-75: LGTM: Newwp-subdomainconditional tag integrates cleanly with prompts and parsing
- Consistent with existing
CONDITIONAL_TAGSstructure.- Will be auto-prompted during initialize() when present in fetched checklists.
- Parser already supports simple tags and their negations (
[tag]/[not:tag]), so no additional logic needed.
|
Let's pause on reviewing/merging this, as I think the rule may more broadly be "no sub-subdomains", regardless of whether the FQDN is an a8c property. Checking here: p1754960067684529-slack-C01M1J49Q75 |
1 participant
Adds a
wp-subdomainprompt to thegithub:add-checklistcommand that can then be used to parse launch checklists found in thespecial-projects-checklistsrepo.Specifically, we want to avoid adding or testing for a
wwwsub-subdomain in thelaunch-site.mdchecklist, since doing so is an unsupported anti-pattern: pMz3w-lWV-p2Summary by CodeRabbit